-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add displayConfig in Hub Catalog, update GalleryDisplayConfigSchema #1747
feat: add displayConfig in Hub Catalog, update GalleryDisplayConfigSchema #1747
Conversation
…hema affects: @esri/hub-common ISSUES CLOSED: 11582
affects: @esri/hub-common
…tps://github.com/Esri/hub.js into f/11582-catalog-results-appearance-configuration
affects: @esri/hub-common
affects: @esri/hub-common
…tps://github.com/Esri/hub.js into f/11582-catalog-results-appearance-configuration
affects: @esri/hub-common
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice work here -- one comment re: showThumbnail, the rest are all minor.
affects: @esri/hub-common
affects: @esri/hub-common
affects: @esri/hub-common
affects: @esri/hub-common
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1747 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 992 1028 +36
Lines 17979 18722 +743
Branches 3199 3397 +198
==========================================
+ Hits 17979 18722 +743 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Viv!
# @esri/hub-common [15.14.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2024-12-03) ### Features * add displayConfig in Hub Catalog, update GalleryDisplayConfigSchema ([#1747](#1747)) ([5d1cb18](5d1cb18))
affects: @esri/hub-common
ISSUES CLOSED: 11582
Description:
Instructions for testing:
Closes Issues: # (if appropriate)
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated
peerDependencies
as needed. CRITICAL our automated release system can not be counted on to updatepeerDependencies
so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.