Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add displayConfig in Hub Catalog, update GalleryDisplayConfigSchema #1747

Merged
merged 16 commits into from
Dec 3, 2024

Conversation

vivzhang
Copy link
Contributor

@vivzhang vivzhang commented Nov 22, 2024

affects: @esri/hub-common

ISSUES CLOSED: 11582

  1. Description:

  2. Instructions for testing:

  3. Closes Issues: # (if appropriate)

  4. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  5. used semantic commit messages

  6. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  7. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

Copy link
Contributor

@jordantsanz jordantsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice work here -- one comment re: showThumbnail, the rest are all minor.

packages/common/src/core/schemas/shared/CatalogSchema.ts Outdated Show resolved Hide resolved
packages/common/src/search/types/IHubCatalog.ts Outdated Show resolved Hide resolved
packages/common/src/content/compose.ts Show resolved Hide resolved
packages/common/src/core/schemas/shared/CatalogSchema.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2626a26) to head (9e7fc34).
Report is 204 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #1747    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          992      1028    +36     
  Lines        17979     18722   +743     
  Branches      3199      3397   +198     
==========================================
+ Hits         17979     18722   +743     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jordantsanz jordantsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Viv!

@vivzhang vivzhang merged commit 5d1cb18 into master Dec 3, 2024
7 checks passed
@vivzhang vivzhang deleted the f/11582-catalog-results-appearance-configuration branch December 3, 2024 19:14
esri-dcdev-2 pushed a commit that referenced this pull request Dec 3, 2024
# @esri/hub-common [15.14.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2024-12-03)

### Features

* add displayConfig in Hub Catalog, update GalleryDisplayConfigSchema ([#1747](#1747)) ([5d1cb18](5d1cb18))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants